Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing page improvements #3192

Merged
merged 15 commits into from
Feb 9, 2021
Merged

Billing page improvements #3192

merged 15 commits into from
Feb 9, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Feb 4, 2021

Changes

This PR introduces a bunch of changes to improve the self-serve billing page for cloud customers.

  • Provide the user with more information around their current plan and allow them to manage their subscription.

  • They can now manage their subscription (we leverage Stripe's customer billing portal) where users can:

    • Cancel their billing subscription
    • Update their card information
    • Update their billing information for invoices (e.g. address)
    • View their past invoices
  • Clarification around current usage (i.e. events not billed yet) and exact number of events.

  • Removes the hide-billing-toolbar feature flag as this was intended for our internal team, but we want to dogfood the billing experience too.

  • Introduce support for default event allowance prior to setting up a billing agreement (i.e. events you can have for free without entering your card information).

  • Related to the above, we will now show an alert on every page if the organization has exceeded 85% of the allocated events in the current month. This will apply for all organizations without a billing agreement, organizations in the startup plan, and organizations in the legacy plans (starter & growth).

  • Plans in the self-serve billing enrollment page now include all the plan details. Plan details are stored in the database and support HTML (using dangerouslySetInnerHTML).

  • Makes it clear when you haven't finished set up your billing agreement and adds a clear step to fix it.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 10:14 Inactive
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 10:31 Inactive
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 10:57 Inactive
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 11:33 Inactive
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 12:09 Inactive
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 4, 2021 15:01 Inactive
@paolodamico paolodamico marked this pull request as ready for review February 4, 2021 15:09
@paolodamico
Copy link
Contributor Author

Tagging @jamesefhawkins, @piemets & @yakkomajuri in case you want to check this out from UX standpoint.

@paolodamico
Copy link
Contributor Author

Ping @Twixes. Also let me know if you prefer someone else take a look :)

Copy link
Contributor

@yakkomajuri yakkomajuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly skimmed the code and looked at the screenshots you provided. UI seems good to me and only added one super nit to the code review which is absolutely non-blocking

frontend/src/lib/components/BillingAlerts.tsx Show resolved Hide resolved
frontend/src/lib/components/BillingAlerts.tsx Outdated Show resolved Hide resolved
frontend/src/lib/components/BillingAlerts.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/BillingEnrollment.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/BillingEnrollment.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/CurrentPlan.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/CurrentUsage.tsx Show resolved Hide resolved
frontend/src/scenes/billing/CurrentUsage.tsx Outdated Show resolved Hide resolved
frontend/src/scenes/billing/billingLogic.ts Outdated Show resolved Hide resolved
frontend/src/scenes/billing/billingLogic.ts Outdated Show resolved Hide resolved
frontend/src/scenes/billing/billingLogic.ts Outdated Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-billing-page-im-tnym23 February 9, 2021 10:13 Inactive
@paolodamico
Copy link
Contributor Author

All feedback has been addressed and complimenting PR merged. Could I trouble you with a final look before I merge?

@Twixes Twixes temporarily deployed to posthog-billing-page-im-tnym23 February 9, 2021 12:40 Inactive
@paolodamico paolodamico merged commit ba7866a into master Feb 9, 2021
@paolodamico paolodamico deleted the billing-page-improvements branch February 9, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants