Fix array.js #436
Merged
Fix array.js #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
approved these changes
Apr 2, 2020
yakkomajuri
pushed a commit
that referenced
this pull request
Oct 1, 2021
* Reorient `ActionManager` to group by teamId for practicality * Make `getTeamActions()` return type more versatile * Add ActionMatcher base * Add `matchActions` worker task for optimization * Add part of action matching checks * Fix PubSub's lack of teamId * Remove `eventsProcessor.prepare()` calls * Add a legit ActionMatcher test * Adjust test for matchActions task * Improve task counting in test * Add moar matching capabilities * Improve tests * Reorganize class dependencies * Add cohort matching * Add element/selector matching and polish other action matching parts * Handle selector matching edge cases * Save matched action occurrences to Postgres * Fix action-matcher tests * Don't expose ActionManager methods in ActionMatcher * Use feedback + RE2 * Remove never satisfied branch * Address sum feedback and clean code up * Use action matching results in a smarter way * Fix `createHub` * Add action matching metric * Enhance `PLUGIN_SERVER_ACTION_MATCHING` * Update action-matcher.test.ts * Remove `||=` * Update process-event.ts * Only fetch person if matching actions * Fix non-string distinct ID handling * Update process-event.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here's what was happening with
array.js.Every time we ran
yarn build, this script was executed:Notice the part after
&&. This overwrote thearray.jsin thedistfolder with the one that was in thepublicfolder. You can also see that the live array.js is this public "prettified" versionI now moved the updated array.js from
distintopublicand removed thedistone from git. The entiredistfolder is in.gitignoreactually. Now whenever you need to copy a new version of the array.js script, please copy it into thepublicfolder and commit it there. It will be automatically moved todist. :)This system of public vs dist has been live now for a while (since the webpack upgrade). Sorry for not communicating this properly before.