Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change more dropdowns to antd #814

Merged
merged 6 commits into from
May 21, 2020
Merged

change more dropdowns to antd #814

merged 6 commits into from
May 21, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented May 20, 2020

Changes

  • action step event dropdown uses antd now
  • cohort group action dropdown uses antd now

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@timgl timgl temporarily deployed to posthog-antd-element-se-gtr75y May 20, 2020 17:36 Inactive
@timgl timgl temporarily deployed to posthog-antd-element-se-gtr75y May 20, 2020 17:57 Inactive
@timgl timgl temporarily deployed to posthog-antd-element-se-gtr75y May 20, 2020 17:59 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review May 20, 2020 18:01
timgl
timgl reviewed May 20, 2020
View reviewed changes
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: spacing isn't quite right here:
image

frontend/src/scenes/actions/EventName.js Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-antd-element-se-gtr75y May 20, 2020 20:03 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented May 20, 2020 •
edited
Loading

Do you mean the action label being cut off or different spacing?

@timgl
Copy link
Collaborator

timgl commented May 20, 2020

I meant different spacing at the bottom, right below the Sign Up Click

@timgl timgl temporarily deployed to posthog-antd-element-se-gtr75y May 21, 2020 13:52 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented May 21, 2020

got it. let me know if the height is better now!

@timgl timgl merged commit 8480856 into master May 21, 2020
@timgl timgl deleted the antd-element-select branch May 21, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @timgl