Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor more classes to hooks #898

Merged
merged 8 commits into from
Jun 1, 2020
Merged

Refactor more classes to hooks #898

merged 8 commits into from
Jun 1, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented May 30, 2020 •
edited
Loading

Changes

  • fix bug where trend graph wasn't showing event names on labels (it was defaulting to '$pageview' instead)
  • refactor more classes to hooks (along with mergin Start point for paths #897 all components will be hooks)

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-more-hooks-refa-qhm2x4 May 30, 2020 18:16 Inactive
@timgl timgl temporarily deployed to posthog-more-hooks-refa-qhm2x4 May 30, 2020 18:42 Inactive
@timgl timgl temporarily deployed to posthog-more-hooks-refa-qhm2x4 May 30, 2020 18:43 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review May 30, 2020 18:49
@timgl timgl temporarily deployed to posthog-more-hooks-refa-qhm2x4 May 30, 2020 19:22 Inactive
@EDsCODE EDsCODE requested a review from timgl June 1, 2020 01:13
timgl
timgl approved these changes Jun 1, 2020
View reviewed changes
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a small issue with team invitation

@timgl timgl temporarily deployed to posthog-more-hooks-refa-qhm2x4 June 1, 2020 08:23 Inactive
@timgl timgl merged commit 48dd7bc into master Jun 1, 2020
@timgl timgl deleted the more-hooks-refactor branch June 1, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @timgl