Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions view #926

Merged
merged 40 commits into from
Jun 16, 2020
Merged

Sessions view #926

merged 40 commits into from
Jun 16, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jun 4, 2020

Changes

Todo:

  • paginated
  • surface all related properties to the person in session
    - [ ] add migrations to create materialized table for prexisting data
  • red indicator for currently in progress

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 4, 2020 19:26 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 13:01 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 18:21 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 19:39 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review June 5, 2020 19:45
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 19:45 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 19:57 Inactive
@timgl timgl had a problem deploying to posthog-sessions-view-qzz6q7bn June 5, 2020 20:01 Failure
@timgl timgl had a problem deploying to posthog-sessions-view-qzz6q7bn June 5, 2020 20:06 Failure
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 5, 2020 20:24 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 6, 2020 17:15 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 8, 2020 00:19 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 19:28 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 19:53 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 19:57 Inactive
@EDsCODE EDsCODE requested a review from timgl June 11, 2020 20:32
@EDsCODE
Copy link
Member Author

EDsCODE commented Jun 11, 2020

@timgl This is ready for another look! I ended up not using materialized views or any database specific optimization strategy because it seemed overkill to manage. I figured out a format of the feature that makes the queries really light. Instead of trying to compute the entire sessions table, I've setup the page to work by day. This actually makes the browsing experience better because you can actually scroll to a specific day and find what people were up to. This way, the queries can be extremely precise and quick.

However, the one inconvenience happens when you reach the end of a specific day. There is a way to fix this but it would lead to another problem where sparsely logged events would make pagination on this page really weird. LMK what you think!

Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When scrolling through this, I really found myself wanting to filter this just by people with email addresses. Could be another ticket though!

Couple small things below

frontend/src/scenes/sessions/SessionDetails.js Outdated Show resolved Hide resolved
frontend/src/scenes/sessions/SessionsTable.js Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 21:04 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 21:13 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 11, 2020 21:14 Inactive
@EDsCODE EDsCODE requested a review from timgl June 12, 2020 13:40
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 12, 2020 13:50 Inactive
@timgl
Copy link
Collaborator

timgl commented Jun 15, 2020

Mergy conflicts

@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 15, 2020 13:07 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 15, 2020 21:03 Inactive
@timgl timgl temporarily deployed to posthog-sessions-view-qzz6q7bn June 16, 2020 08:52 Inactive
@timgl timgl merged commit 65fedb2 into master Jun 16, 2020
@timgl timgl deleted the sessions-view branch June 16, 2020 11:49
@mariusandra
Copy link
Collaborator

I found one thing: when you change the pagination, the "order" still starts from "1", even if it should probably start from 51:

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants