Cache yarn builds to speed up end to end testing #927
Conversation
|
First successful run: Second run: |
There was a problem hiding this comment.
This looks awesome. Forgoing the docker setup is probably the better way to go about it as there's too much overhead and because our system is still small enough to spin up nicely within an action. I have a few questions below but otherwise it lgtm
*One thing to note is that I'm not able to test if updating dependencies/tests will update the cache accordingly without committing changes but if you're able to confirm the cache works as expected I'm good with this
.github/workflows/e2e.yml
Outdated
| DATABASE_URL: 'postgres://postgres:postgres@localhost:${{ job.services.postgres.ports[5432] }}/postgres' | ||
| DISABLE_SECURE_SSL_REDIRECT: 1 | ||
| OPT_OUT_CAPTURE: 1 | ||
| DEBUG: 1 |
There was a problem hiding this comment.
What was the difference that warranted continue to use DEBUG deployment rather than a prod as marius had originally replaced?
There was a problem hiding this comment.
I was having a hard time getting the demo environment to run.
Let me check that again real quick
| uses: actions/upload-artifact@v1 | ||
| with: | ||
| name: screenshots | ||
| path: cypress/screenshots |
There was a problem hiding this comment.
Where do we access these screenshots?
There was a problem hiding this comment.
They only are captured if cypress tests fails, but you can grab them at the top right of the log page:
🤞 This will speed things up for end to end tests