Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Currency Lists in the code base #89

Closed
PostScripton opened this issue Aug 6, 2022 · 1 comment
Closed

Get rid of Currency Lists in the code base #89

PostScripton opened this issue Aug 6, 2022 · 1 comment
Labels
invalid This doesn't seem right
Milestone

Comments

@PostScripton
Copy link
Owner

PostScripton commented Aug 6, 2022

I've decided to get rid of Currency Lists because of their overwhelming compelexity in the realisation. It would be simplier to set a Currency List only in the config file but not in the code.

It doesn't meant to get rid of it entirely but of it from the methods such as:

  • Currency::currentList()
  • Currency::setCurrencyList()
  • Currency::isIncorrectList()
    and of the constants:
  • LIST_ALL
  • LIST_POPULAR
  • LIST_CUSTOM
  • LIST_CONFIG
  • LISTS
@PostScripton PostScripton added the invalid This doesn't seem right label Aug 6, 2022
@PostScripton PostScripton added this to the v4.0 milestone Aug 6, 2022
@PostScripton
Copy link
Owner Author

Done here: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant