Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Properly update rcode-related metrics on RCodeAction hits #12484

Merged
merged 2 commits into from
Jan 30, 2023
Merged

dnsdist: Properly update rcode-related metrics on RCodeAction hits #12484

merged 2 commits into from
Jan 30, 2023

Conversation

rgacogne
Copy link
Member

Short description

Fixes #11498.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jan 27, 2023
@rgacogne rgacogne merged commit 77b3110 into PowerDNS:master Jan 30, 2023
@rgacogne rgacogne deleted the ddist-fix-rcode-metrics-rcodeaction branch January 30, 2023 09:56
@rgacogne rgacogne mentioned this pull request Mar 6, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

dnsdist: Be consistent about "ruleRefused", "ruleNXDomain" and "ruleServFail" counters
2 participants
@rgacogne @chbruyand