-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old Lua code #5390
Remove old Lua code #5390
Conversation
3d9d57c
to
4bf7f98
Compare
19b24a8
to
00ff833
Compare
Currently stuck at __tostring The LuaContext used keeps the functions available stored in global table. I have not yet been able to decipher how the mapping between object<=>function name<=>function is done, but it seems to rely on pointer to the proper member function. This makes things difficult. I am assuming that there is, somewhere, some way to find out what It is possible to get a live pointer to the C++ object in question, but I have not yet found a way to execute ::toString only if there is such member function, or figure out how to see if there is a _tostring function mapped for the object or not. It is probably easier to find out the latter than the first, since this information is kept at global function table stored somewhere. |
410e07a
to
b1b1e48
Compare
Please merge #5468 first |
4dce79f
to
df0ac30
Compare
Also pending on ahupowerdns/luawrapper#35 |
a09fe99
to
abc5949
Compare
Not sure why the test fails, I cannot make it fail locally. |
8d8ee59
to
3a49f77
Compare
The reason the tests fail is that recursor test uses pdns auth server 4.0.4, which is obviously not going to include the lua changes done here. I am not sure how to resolve this problem, please advise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one question. This looks good, nice chunk of work. I'd like either a second reviewer, or to merge this after both 4.1.0 releases.
@@ -136,6 +136,9 @@ bool AuthLua4::axfrfilter(const ComboAddress& remote, const DNSName& zone, const | |||
|
|||
|
|||
bool AuthLua4::updatePolicy(const DNSName &qname, QType qtype, const DNSName &zonename, DNSPacket *packet) { | |||
// default decision is all goes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a documentation update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's just explicitly documented here.
0ee4c76
to
6a5f89e
Compare
3148deb
to
67f23cb
Compare
In the "ext/luawrapper: Synchronize with upstream" commit message, can you clarify synchronize? If it is a full sync, please mention the commit you synced with. If it's an import of one patch, please mention that. |
Allows code sharing between recursor and auth
This changes how prequery gets called
Short description
Removes all old lua code from PowerDNS auth server, and provides codesharing between auth and recursor.
Checklist
I have: