Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Use toStringWithPort instead of manual addr/port concat #9222

Merged
merged 1 commit into from
Jul 31, 2020
Merged

dnsdist: Use toStringWithPort instead of manual addr/port concat #9222

merged 1 commit into from
Jul 31, 2020

Conversation

supervacuus
Copy link
Contributor

Fixes #9075

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@supervacuus
dnsdist: Use toStringWithPort instead of manual addr/port concat
ede22b6 
Doing manual string concatenation like

address + ":" + port

leads to incorrectly rendered front-end labels in the metrics endpoint
when using IPv6 addresses. The same concatenation pattern was used in
the carbon-dump.
@zeha zeha added the dnsdist label Jun 11, 2020
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Jun 15, 2020
@rgacogne rgacogne merged commit 5f3857e into PowerDNS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

dnsdist: in metrics, frontend label has wrong IPv6 formatting
3 participants
@supervacuus @rgacogne @zeha