Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1755 Disable PictureSlidesLab on empty presentation #1776

Conversation

ChesterSng
Copy link
Contributor

Fixes #1755

  1. Disable PictureSlidesLab Button when there are no slides
  2. Disable PictureSlidesLab Button and close existing PictureSlidesLab window when last slide is removed

Outline of Solution
This PR follows PR 1715 closely to disable the PictureSlidesLab button when there are no slides in the presentation.

@ChesterSng ChesterSng changed the title 1755 disable pictureslideslab on empty presentation #1755 Disable PictureSlidesLab on empty presentation Feb 12, 2019
@ChesterSng ChesterSng requested review from blewjy and removed request for blewjy February 12, 2019 08:03
Copy link
Contributor

@blewjy blewjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on PPT 2013, Windows 10. A couple of comments...

@blewjy blewjy added the ok-2013 label Feb 12, 2019
@blewjy
Copy link
Contributor

blewjy commented Feb 16, 2019

Tested and working on both PPT2016 and PPT2010!

@leeyh20 leeyh20 merged commit 2c6ba4e into PowerPointLabs:dev-release Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants