#1647 TimerLab error when no slides selected or empty ppt #1715
Conversation
LiXiaoooowei
changed the title
| @@ -0,0 +1,9 @@ | |||
| namespace PowerPointLabs.TimerLab | |||
| { | |||
| internal static class NotesToTimer | |||
There was a problem hiding this comment.
May I know why this class is called NotesToTimer? Or is there any better place to put IsTimerEnabled?
There was a problem hiding this comment.
@LiXiaoooowei Would you be updating this PR?
There was a problem hiding this comment.
@initialshl I am trying to follow the names set by other labs for similar functionalities, i.e. NotesToAudio and NotesToCaption.
There was a problem hiding this comment.
Hmm I think that the NotesToAudio and NotesToCaption refers to the slide's speaker's notes (for text-to-speech). You may want to change it to just TimerLab.cs
There was a problem hiding this comment.
@initialshl Code edited according to suggestion.
|
@LiXiaoooowei Could this be tested on PPT2013? |
|
Tested on PPT2013. Working as described! |
Fixes #1647
Tested in PPT2016.
Changes:
Greyed out TimerLab ribbon button when no slide is selected or ppt is empty.
Remove TimerPane when TimerLab is previously opened but no slides selected later.