Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors #1036

Closed
vors opened this issue May 25, 2016 · 12 comments
Closed

Colors #1036

vors opened this issue May 25, 2016 · 12 comments
Assignees
Labels
Issue-Bug Issue has been identified as a bug in the product OS-Linux OS-macOS Resolution-External The issue is caused by external component(s). Usability (LEGACY) Helps filter issues that might be higher priority because they directly affect usability WG-Interactive-Console the console experience WG-Interactive-PSReadLine PSReadline related issues

Comments

@vors
Copy link
Collaborator

vors commented May 25, 2016

Steps to reproduce

  • Open terminal in OS X, with "Basic" (default) color schema.
  • Run powershell
  • run throw "foo"

Expected behavior

Colors look ok

Actual behavior

Colors don't look ok

image

Environment data

v0.4.0

cc @nanalakshmanan

@andyleejordan andyleejordan added the Usability (LEGACY) Helps filter issues that might be higher priority because they directly affect usability label May 26, 2016
@andyleejordan andyleejordan modified the milestones: Future, Aug17 Jun 8, 2016
@andyleejordan andyleejordan added the WG-Interactive-PSReadLine PSReadline related issues label Jun 9, 2016
@vors
Copy link
Collaborator Author

vors commented Jun 9, 2016

It's not only OS X actually.

This is from Ubuntu Server 14.04, terminal emulator with default colors

image

@vors vors changed the title Colors on OS X Colors Jun 9, 2016
@vors
Copy link
Collaborator Author

vors commented Jun 10, 2016

This is unacceptable

image

@joeyaiello
Copy link
Contributor

There's two issues here:

  • There's some non-PSReadline code that's overriding the background color of errors. We may want to remove this code now that PSReadline is the engine for changing colors.
  • PSReadline should have proper theme support (with at least light and dark themes, but potentially a host of others).

@hiteshraigandhi hiteshraigandhi modified the milestones: 6.0.0-alpha.9, Aug17 Jul 28, 2016
@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-Alpha.11, 6.0.0-alpha.9 Aug 4, 2016
@twblalock
Copy link

I'm able to set some of the colors on Mac OS, but the names of commands as I type them out remain yellow no matter what.

@joeyaiello joeyaiello added WG-Interactive-Console the console experience Issue-Bug Issue has been identified as a bug in the product labels Sep 2, 2016
@lzybkr
Copy link
Member

lzybkr commented Nov 9, 2016

This issue was moved to PowerShell/PSReadLine#472

@lzybkr lzybkr closed this as completed Nov 9, 2016
@Oxicode
Copy link

Oxicode commented Nov 11, 2016

+1 Ubuntu

@joeyaiello joeyaiello added the Resolution-External The issue is caused by external component(s). label Nov 29, 2016
@jszabo98
Copy link

jszabo98 commented Jun 3, 2017

The default colors aren't great in osx, especially white on white for numbers and members, yellow for commands, and gray for types and operators. (I'm not a fan of the red error messages in Windows either.)

Btw when I tab complete on set-psreadlineoption or get-psreadlineoption in osx, it pops up twice.

@joeyaiello
Copy link
Contributor

@jszabo98 agreed on all fronts. The tab-completion bug is known too (I think it's somewhere in the PSReadline repo)

@milindsaraswala
Copy link

I am late to the party but I found the article which make your mac terminal window same like windows PowerShell. By Setting Profile. Please follow this below article
https://info.sapien.com/index.php/quickguides/setting-up-powershell-on-your-mac

@casperghst42
Copy link

We are not 4 years down the line, and there has been absolutely no update. It is interesting as Microsoft are now trying the "Run Everywhere" idea, but they are failing to make it a nice experience.

@jszabo98
Copy link

My current setup. I just did this on a new mac.

set-psreadlineoption -colors @{ 
  command            = 'darkyellow'
  number             = 'black'
  member             = 'black'
  operator           = 'black'
  type               = 'black'
  variable           = 'darkgreen'
  parameter          = 'darkgreen'
  continuationprompt = 'black'
  default            = 'black'
}

$host.PrivateData.VerboseForegroundColor = 'DarkYellow'
$host.PrivateData.WarningForegroundColor = 'DarkYellow'
$host.PrivateData.DebugForegroundColor = 'DarkYellow'
$host.PrivateData.ProgressForegroundColor = 'DarkYellow'

@casperghst42
Copy link

My current setup. I just did this on a new mac.

set-psreadlineoption -colors @{ 
  command            = 'darkyellow'
  number             = 'black'
  member             = 'black'
  operator           = 'black'
  type               = 'black'
  variable           = 'darkgreen'
  parameter          = 'darkgreen'
  continuationprompt = 'black'
  default            = 'black'
}

$host.PrivateData.VerboseForegroundColor = 'DarkYellow'
$host.PrivateData.WarningForegroundColor = 'DarkYellow'
$host.PrivateData.DebugForegroundColor = 'DarkYellow'
$host.PrivateData.ProgressForegroundColor = 'DarkYellow'

Thanks, very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Issue has been identified as a bug in the product OS-Linux OS-macOS Resolution-External The issue is caused by external component(s). Usability (LEGACY) Helps filter issues that might be higher priority because they directly affect usability WG-Interactive-Console the console experience WG-Interactive-PSReadLine PSReadline related issues
Projects
None yet
Development

No branches or pull requests