-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error-reporting in some WinCompat scenarios #11259
Merged
adityapatwardhan
merged 6 commits into
PowerShell:master
from
anmenaga:ShowRemotingError
Dec 9, 2019
Merged
Fix error-reporting in some WinCompat scenarios #11259
adityapatwardhan
merged 6 commits into
PowerShell:master
from
anmenaga:ShowRemotingError
Dec 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
added
the
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
label
Dec 3, 2019
anmenaga
changed the title
WIP: Fix error-reporting in some WinCompat scenarios
Fix error-reporting in some WinCompat scenarios
Dec 5, 2019
iSazonov
reviewed
Dec 6, 2019
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Outdated
Show resolved
Hide resolved
SteveL-MSFT
reviewed
Dec 9, 2019
rjmholt
reviewed
Dec 9, 2019
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
approved these changes
Dec 9, 2019
adityapatwardhan
approved these changes
Dec 9, 2019
TravisEz13
pushed a commit
that referenced
this pull request
Dec 11, 2019
🎉 Handy links: |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
MustHave
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is basically a refactoring/optimization of certain WinCompat scenarios that replaces
PowerShell.Create().AddCommand(ImportModuleCommand).Invoke()
with a direct call to the target code that does WinCompat-loading of the module.CommandDiscovery/ModuleAutoload
scenarios which improves user experience like in issue CertificateProvider auto-imports PKI module many times #11241PowerShell.Create().Invoke()
with a simple function call.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.