Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error-reporting in some WinCompat scenarios #11259

Merged
merged 6 commits into from
Dec 9, 2019

Conversation

anmenaga
Copy link
Contributor

@anmenaga anmenaga commented Dec 3, 2019

PR Summary

This PR is basically a refactoring/optimization of certain WinCompat scenarios that replaces PowerShell.Create().AddCommand(ImportModuleCommand).Invoke() with a direct call to the target code that does WinCompat-loading of the module.

PR Checklist

@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 3, 2019
@anmenaga anmenaga changed the title WIP: Fix error-reporting in some WinCompat scenarios Fix error-reporting in some WinCompat scenarios Dec 5, 2019
@adityapatwardhan adityapatwardhan merged commit f8a321a into PowerShell:master Dec 9, 2019
@TravisEz13 TravisEz13 removed this from the rc.1-approved milestone Dec 11, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-rc.1 milestone Dec 11, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log MustHave
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants