Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why PackageVersion is used in PowerShell.Common.props #12523

Merged

Conversation

xtqqczze
Copy link
Contributor

PR Summary

Update documentation of why PackageVersion is used in PowerShell.Common.props.

Explanation is copied from @nguerrera comment at dotnet/sdk

PR Checklist

Add documentation of why `PackageVersion` is used in `PowerShell.Common.props`. Explamation is copied from [dotnet/sdk](dotnet/sdk#1557 (comment))

Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
@TravisEz13 TravisEz13 added the AutoMerge informs the bot to automerge the PR label Apr 29, 2020
@ghost
Copy link

ghost commented Apr 29, 2020

Hello @TravisEz13!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 18 hours 33 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@TravisEz13 TravisEz13 added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 29, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.3 milestone Apr 29, 2020
@TravisEz13 TravisEz13 changed the title Document why PackageVersion is used in PowerShell.Common.props Document why PackageVersion is used in PowerShell.Common.props Apr 30, 2020
@TravisEz13 TravisEz13 merged commit ef1c0d7 into PowerShell:master Apr 30, 2020
@iSazonov iSazonov assigned TravisEz13 and unassigned daxian-dbw Apr 30, 2020
@xtqqczze xtqqczze deleted the update-PackageVersion-csproj-comment branch April 30, 2020 20:53
@ghost
Copy link

ghost commented May 19, 2020

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge informs the bot to automerge the PR CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants