Update .NET SDK version from 5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.13
#12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
assigned 
|
@PoshChan please retry static |
|
@daxian-dbw, successfully started retry of |
|
@adityapatwardhan Can you please take a look? Nothing changed in |
daxian-dbw
added
the
CL-BuildPackaging
|
It seems only the SDK version changed and no packages or runtime changes. I believe we can decide to not take this PR and wait for one which has other changes too. |
github-actions
bot
force-pushed
the
dotnet_update
branch
from
b516590
to
a91f9d8
Compare
github-actions
bot
changed the title
5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20272.95.0.100-preview.5.20272.6 to 5.0.100-preview.5.20276.15
|
@daxian-dbw Let me verify that there are no changes other changes. Something does not seem right. |
|
@daxian-dbw there is actually no change to dependency versions only the sdk version updated. |
github-actions
bot
force-pushed
the
dotnet_update
branch
from
a91f9d8
to
3ab4548
Compare
github-actions
bot
changed the title
5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20276.155.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.1
|
@daxian-dbw I think this can be merged. |
…preview.5.20278.13`
github-actions
bot
changed the title
5.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.15.0.100-preview.5.20272.6 to 5.0.100-preview.5.20278.13
github-actions
bot
force-pushed
the
dotnet_update
branch
from
3ab4548
to
2a649ce
Compare
github-actions
bot
requested review from
anmenaga,
daxian-dbw and
TravisEz13
as code owners
daxian-dbw
approved these changes
May 29, 2020
This was referenced Jun 1, 2020
ghost
pushed a commit
that referenced
this pull request
Jun 2, 2020
# PR Summary * Increase the list capacity because .NET v5.0.100-preview.5.20278.13 has an extra assembly * Remove assert added in #12520 ## PR Context HEAD of master has been broken since 99da109 (#12772), when .NET was updated to 5.0.100-preview.5.20278.13 #12815 (comment) ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [x] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here --> - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed: <!-- Number/link of that issue here --> - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action