Expand numberOfPowershellRefAssemblies list capacity

[xtqqczze]

PR Summary

• Increase the list capacity because .NET v5.0.100-preview.5.20278.13 has an extra assembly
• Remove assert added in Clarify defaultRefAssemblies list capacity in AddType.cs #12520

PR Context

HEAD of master has been broken since 99da109 (#12772), when .NET was updated to 5.0.100-preview.5.20278.13

#12815 (comment)

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[adityapatwardhan]

@xtqqczze Please use a more descriptive PR title.

[xtqqczze]

This resolves the issue in #12815 (comment) but does not fix #12815 as it does not include a static test.

[xtqqczze]

@TravisEz13 can you help merge to resolve the breakage described in #12815 (comment)

[vexx32]

@TravisEz13 and @adityapatwardhan probably best to get this merged sooner than later; folks can't currently run debug builds at all while this is an issue.

[xtqqczze]

@iSazonov since you merged #12520, which this PR partially reverts, can you help merge this PR?

[xtqqczze]

The capacity is now 161 as per @iSazonov suggestion.

[xtqqczze]

@TravisEz13 ready to merge?

[ghost]

Hello @iSazonov!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes