Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '-PipelineVariable' to set variable in the right scope #16199

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

daxian-dbw
Copy link
Member

PR Summary

Fix #16155

Fix '-PipelineVariable' to set variable in the right scope and to not remove the pipeline variable at the end of pipeline when it's actually using an already existing variable.

PR Checklist

@ghost ghost assigned rjmholt Oct 5, 2021
Copy link
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we the same issue for other variables like OutVariable?

@daxian-dbw
Copy link
Member Author

No, only pipeline variable is special.

@rjmholt rjmholt merged commit e98a8c8 into PowerShell:master Oct 7, 2021
@rjmholt rjmholt added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed CL-Engine Indicates that a PR should be marked as an engine change in the Change Log labels Oct 7, 2021
@daxian-dbw daxian-dbw deleted the pv branch October 7, 2021 17:29
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipelineVariable throws error if variable name used exists in function definition
3 participants