-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move psxml type definitions from SMA to Security module #16355
Conversation
I want to point out that this PR would also fix #14095 😃 |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
i think the strong argument here is the breaking of the circular dependency. |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@SteveL-MSFT and @JamesWTruher This is a breaking change:
Are you fine to accept this breaking change? |
@daxian-dbw I did a search on GitHub for use of |
I think the general use case is going to because someone invoked |
/rebase |
Started rebase: https://github.com/PowerShell/PowerShell/actions/runs/2736080597
|
2f5ae26
to
d17a373
Compare
Just checked on Linux, Access Control List APIs are only supported on Windows, so the changes to |
🎉 Handy links: |
PR Summary
Replace #16349
Fix #14095
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).