-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure alpine and arm SKUs have powershell.config.json file with experimental features enabled #16823
Ensure alpine and arm SKUs have powershell.config.json file with experimental features enabled #16823
Conversation
8dd5d57
to
6a226ff
Compare
@TravisEz13 @daxian-dbw Please re-review |
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
🎉 Handy links: |
…perimental features enabled (PowerShell#16823)
…perimental features enabled (PowerShell#16823) # Conflicts: # build.psm1
…perimental features enabled (PowerShell#16823) # Conflicts: # build.psm1
🎉 Handy links: |
🎉 Handy links: |
PR Summary
We needed to invoke pwsh to generate the list of experimental features. Hence, it did not work on cross compiled packages like ARM and Alpine. Now we have static file with the experimental feature list. This is used as the source of truth for listing the experimental feature to be included in the powershell.config.json.
Updated build configurations to use the experimental files json.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).