New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automation to update experimental json files in GitHub action #16837
Fix automation to update experimental json files in GitHub action #16837
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Why do we generate the file at all? If I understand correctly we need to explicitly turn on all experimental features in preview builds and turn off (that is default) all experimental features in release builds.
|
I think @iSazonov has a good point. If we enforce this in code, then there is no need to manipulate the JSON files in our build. |
There is no harm to use the pre-populated experimental feature list for now. If the code change is done in future, we can easily move away from it. |
I also like the idea from @iSazonov for PS to make the decision to enable / disable. We could do that as followup. This work will unblock the issues on alpine for next preview. |
🎉 Handy links: |
PR Summary
Create a GitHub action to run daily and create PR for updating json files for experimental features
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).