-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SupportsShouldProcess in Stop-Transcript #18731
Implement SupportsShouldProcess in Stop-Transcript #18731
Conversation
@JohnLBevan Please fix test.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@JohnLBevan Thanks for your contribution! |
Thank-you for your helpful feedback, and for accepting the PR. |
PR Summary
Fix #18730.
Implemented
SupportsShouldProcess
on cmdletStop-Transcript
.PR Context
Avoids issues where Start-Transcript hasn't run because of a WhatIf flag sent to the parent cmdlet, whilst Stop-Transcript in the same cmdlet would have thrown an exception.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).