-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Help proxy function for non-Windows platforms #19972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build seems to be failing due to preprocessor statements not being correct. Please check.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Summary
Add
Help
proxy function for non-Windows platforms.help
function includes the-ShowWindow
parameter on non-Windows platforms #19904PR Context
The original proxy function had been updated to support non-Windows platforms, however, it included the
-ShowWindow
parameter, which is not supported or available on macOS and Linux.This PR creates two versions of the proxy function:
more.com
orless
depending on the platform. Now defaults tomore.com
.-ShowWindow
parametermore.com
orless
depending on the platform. Now defaults toless
.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).