-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build to .NET 8 preview 6 #19991
Move build to .NET 8 preview 6 #19991
Conversation
src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/CimJobException.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
0441695
to
895044a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dismiss my review as more changes were pushed.
The Windows xunit test issue is a known issue with MMI.dll and .NET 8 newer previews. I believe @adityapatwardhan has a workaround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked at changes
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
b8f5653
to
3e8b88f
Compare
@SteveL-MSFT - please look at CI failures |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need support to resolve this issue.
If you can take the needed initiative for resolving this issue that will be highly appreciated. Regards, |
PR Summary
Errors were from additional method analysis that methods not using instance data should be marked as static. Addressed all the reported errors.
Constructor for a marshaled type has to be public due to breaking change in .NET 8.
Needed to rev isolation test module to use 13.0.0.1 of NewtonSoft as anything older gets flagged due to a security issue. Changed test to check file location instead of version.
Removed win-arm build as some assemblies for .NET 8 don't appear to be published for win-arm anymore since .NET dropped support for it.
PR Context
Moving to .NET 8 preview 6
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).