Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes in official build pipeline #21408

Merged
merged 15 commits into from Apr 3, 2024

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Apr 3, 2024

PR Summary

Fix couple of issues found during development of packaging pipeline

PR Context

PR Checklist

@TravisEz13
Copy link
Member

Should we add a version parameter rather than relying on the branch name. Let's talk and discuss what I'm thinking and other compliance requirements.

@adityapatwardhan adityapatwardhan added Backport-7.2.x-Approved Backport-7.3.x-Approved BackPort-7.4.x-Approved CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Apr 3, 2024
@TravisEz13 TravisEz13 merged commit 94d6231 into PowerShell:master Apr 3, 2024
40 checks passed
@adityapatwardhan adityapatwardhan deleted the NewBuildChanges branch April 3, 2024 22:06
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 3, 2024

📣 Hey @adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Moazzem-Hossain-pixel
Copy link

Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done Backport-7.3.x-Done BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants