Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back 2 transitive dependency packages #21415

Merged
merged 1 commit into from Apr 4, 2024

Conversation

daxian-dbw
Copy link
Member

PR Summary

Fix #21324

Explicitly put those 2 transitive dependencies back to Microsoft.PowerShell.SDK.csproj.
Due to the removal of them, PS v7.4 ships old versions of the assembly Microsoft.Bcl.AsyncInterfaces.dll and Microsoft.Extensions.ObjectPool.dll comparing to PS v7.3.

After adding back the references, PS will includes the latest stable versions:
 
image

PR Checklist

@daxian-dbw daxian-dbw self-assigned this Apr 3, 2024
@daxian-dbw daxian-dbw added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Approved labels Apr 3, 2024
@iSazonov
Copy link
Collaborator

iSazonov commented Apr 4, 2024

Interesting, how many dependencies does pwsh have? Is it worth keeping track of this to avoid regression?

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeeminglyScience
Copy link
Collaborator

Interesting, how many dependencies does pwsh have? Is it worth keeping track of this to avoid regression?

FWIW we do run a tool as part of the release to check for transitive updates. It's only major versions that we'll potentially miss - but usually we don't necessarily want to take those anyway. The ones we do want to take should be pretty rare.

@daxian-dbw daxian-dbw merged commit 1a52a93 into PowerShell:master Apr 4, 2024
40 checks passed
@daxian-dbw daxian-dbw deleted the transitive branch April 4, 2024 18:41
Copy link
Contributor

microsoft-github-policy-service bot commented Apr 4, 2024

📣 Hey @daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PowerShell 7.2 and 7.4 bundle deprecated Microsoft.Bcl.AsyncInterfaces 5.0.0.0
3 participants