Update reference to use packages from NuGet.org #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Aug 14, 2018
| using System.Management.Automation; | ||
| using System.Security; | ||
| using Microsoft.Management.Infrastructure; |
There was a problem hiding this comment.
All System* namespaces must be listed at top.
test/hosting/test_HostingBasic.cs
Outdated
|
|
||
| using (System.Management.Automation.PowerShell ps = System.Management.Automation.PowerShell.Create()) | ||
| { | ||
| string command = $"New-Item -ItemType SymbolicLink -Path {path} -Target {target}"; |
There was a problem hiding this comment.
Is this test because symlink depends on libpsl? Perhaps add a comment as Native may be interpreted as a native command not from Microsoft.PowerShell.Native
There was a problem hiding this comment.
I will add a comment.
|
@SteveL-MSFT Addressed feedback, please have another look. |
TravisEz13
changed the title
TravisEz13
approved these changes
Aug 15, 2018
|
restarted appveyor due to a PSVersion failure |
SteveL-MSFT
approved these changes
Aug 16, 2018
adityapatwardhan
changed the title
|
We need to update Microsoft.PowerShell.Native nuget package with adding new dependencies to pwrshcommon.cpp. Then update the csproj to take a dependency on the new version. |
TravisEz13
approved these changes
Aug 16, 2018
* Update psrp and libpsl reference to Microsoft.PowerShell.Native * Keep the reference to powershell.myget.org in nuget.config for PSDesiredStateConfiguration and PowerShellHelpFiles * Update hosting tests * Update hosting.tests.csproj in preparation on next release with version 6.1.0-rc.1 * Update Microsoft.Management.Infrastructure to version 1.0.0
adityapatwardhan
force-pushed
the
UpdateToNuGet
branch
from
d4efe38
to
62446c9
Compare
adityapatwardhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests