Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file blocking issue with webcmdlets #7676

Merged
merged 2 commits into from
Sep 1, 2018

Conversation

Claustn
Copy link
Contributor

@Claustn Claustn commented Aug 31, 2018

PR Summary

Resolve #7669.

Allows multiple uploads of the same file in parallel

This PR changes how -InFile parameter on the Web cmdlets open file handles. Previously the file was opened with ShareAccess None, meaning that the file was locked, resulting in that you, for instance, was not able to upload the same file to multiple destinations in parallel.

PR Checklist

@iSazonov iSazonov self-assigned this Aug 31, 2018
@iSazonov iSazonov changed the title Fix file blocking issue with webcmdlets using -InFile Issue #7669 Fix file blocking issue with webcmdlets Aug 31, 2018
@iSazonov
Copy link
Collaborator

@Claustn Thanks! I slightly corrected the PR title and description.

@iSazonov
Copy link
Collaborator

@Claustn Please rename your commit - start title with [Feature] or add new empty commit with title [Feature] - this will run full test set.

Copy link
Collaborator

@powercode powercode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iSazonov
Copy link
Collaborator

CI Appveyor temporary failed.

Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@markekraus markekraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My approval is pending successful completion of all [feature] tests.

@Claustn Claustn force-pushed the fix/webcmdlets_infile_blocking branch from c32a3a5 to 5f70274 Compare September 1, 2018 10:05
@iSazonov iSazonov merged commit eb92b14 into PowerShell:master Sep 1, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 1, 2018

@Claustn Thanks for discovering the issue and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webcmdlets using -InFile parameter locks file
6 participants