Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files
#8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested changes
Jan 24, 2019
tools/packaging/projects/reference/System.Management.Automation.csproj
Outdated
Show resolved
Hide resolved
tools/packaging/projects/reference/System.Management.Automation.csproj
Outdated
Show resolved
Hide resolved
daxian-dbw
added
the
CL-BuildPackaging
adityapatwardhan
approved these changes
Jan 24, 2019
|
Verified by build https://mscodehub.visualstudio.com/PowerShellCore/_build%2Fresults?buildId=72005&_a=summary |
|
We may need to tell dependabot to rescan the repo after this is merged. |
TravisEz13
approved these changes
Jan 24, 2019
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
May 14, 2019
…eapp2.1` and use actual `.csproj` files (PowerShell#8729) # Conflicts: # tools/packaging/packaging.psm1 # tools/packaging/packaging.strings.psd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update packaging script to build reference assembly targeting
netcoreapp2.1and use actual.csprojfiles.Fix #8721
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests