Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk: correct volume error - drive is read only #190

Merged
merged 52 commits into from
Mar 2, 2019

Conversation

JoshuaJSwain
Copy link
Contributor

@JoshuaJSwain JoshuaJSwain commented Feb 14, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • [X ] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

KarolKaczmarek and others added 30 commits February 2, 2016 16:53
Release of version 2.4.0.0 of xStorage
Release of version 2.6.0.0 of xStorage
Release of version 2.9.0.0 of xStorage
Release of version 3.0.0.0 of xStorage
Release of version 3.1.0.0 of xStorage
Release of version 3.2.0.0 of xStorage
Release of version 3.3.0.0 of xStorage
Release of version 3.4.0.0 of xStorage
Release of version 4.0.0.0 of StorageDsc
Release of version 4.1.0.0 of StorageDsc
Release of version 4.2.0.0 of StorageDsc
Release of version 4.3.0.0 of StorageDsc
Release of version 4.4.0.0 of StorageDsc
@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #190 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #190    +/-   ##
===================================
+ Coverage   94%    94%   +<1%     
===================================
  Files        8      8            
  Lines      886    889     +3     
===================================
+ Hits       834    837     +3     
  Misses      52     52

@PlagueHO PlagueHO changed the title Jswain xdisk rawfix Disk: correct volume error - drive is read only Feb 14, 2019
@PlagueHO PlagueHO self-requested a review February 15, 2019 05:47
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Feb 15, 2019
DSCResources/MSFTDSC_Disk/MSFTDSC_Disk.psm1 Outdated Show resolved Hide resolved
Tests/Unit/MSFTDSC_Disk.Tests.ps1 Outdated Show resolved Hide resolved
@PlagueHO
Copy link
Member

Sorry @JoshuaJSwain - I couldn't use reviewable because something is going weird due to the reverted PR. I actually noticed a few things that needed fixing in this PR.

@PlagueHO PlagueHO added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Feb 16, 2019
@JoshuaJSwain
Copy link
Contributor Author

HI @PlagueHO any further fixes I can work on for this one?

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some really minor tweaks @JoshuaJSwain and I'll merge. Couldn't use Reviewable because of some strangeness with the button.

CHANGELOG.md Outdated Show resolved Hide resolved
DSCResources/MSFTDSC_Disk/MSFTDSC_Disk.psm1 Outdated Show resolved Hide resolved
DSCResources/MSFTDSC_Disk/MSFTDSC_Disk.psm1 Show resolved Hide resolved
@JoshuaJSwain
Copy link
Contributor Author

thanks @PlagueHO I've pushed the updates

@PlagueHO
Copy link
Member

PlagueHO commented Mar 2, 2019

:lgtm:

I'm going to squash merge this.

@PlagueHO PlagueHO merged commit e6dcdde into dsccommunity:dev Mar 2, 2019
@JoshuaJSwain
Copy link
Contributor Author

I see this in dev, curious to see what the release tempo is for 4.6.0.0. I also work on pr 198 when your unit test pr 201 is merged

@PlagueHO
Copy link
Member

The DSC Resource kit is released monthly. Usually the week after the community call. So I'd expect the next release date is in the week starting the 1st of April.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants