Format samples #272
Merged
Format samples #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(sorry fo not splitting the commit) * Removed some samples that didn't seem to provide any good value, we still have way too many or so it seems. Some showcase features some are just plain benchmark examples. Maybe split them? Not sure. * apply formatter to all our samples - want them nice and tidy ey?
* Keep top level measure function, we can put a deprecation warning here when we add them * don't force users to pass along options if there aren't any to `Benchee.Formatter.output/3`
devonestes
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done is in the commits, could be reviewed by them but mostly elixir format, removing some samples and a drive by compatibility change.
Let me know if we should delete any more samples or keep some of the ones I deleted.