Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: tests/client/test_base_client.py::TestCsrfSupport::test_refreshes_token_on_csrf_403 #13963

Closed
1 task done
desertaxle opened this issue Jun 12, 2024 · 2 comments
Closed
1 task done

Flaky test: tests/client/test_base_client.py::TestCsrfSupport::test_refreshes_token_on_csrf_403 #13963

desertaxle opened this issue Jun 12, 2024 · 2 comments
Labels
development Tech debt, refactors, CI, tests, and other related work.

Comments

@desertaxle
Copy link
Member

desertaxle commented Jun 12, 2024 •
edited
Loading

First check

  • I am a contributor to the Prefect codebase

Description

Example of failure: https://github.com/PrefectHQ/prefect/actions/runs/9483315777/job/26130121156

It appears a rogue Runner is running during this test and messing up the httpx mock used by this test. We need to track down the Runner from another test that isn't being stopped correctly or we need to reduce the scope of the httpx mock.

Impact

No response

Additional context

No response
@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Jun 12, 2024
@jlowin jlowin mentioned this issue Jun 17, 2024
Merged
@chrisguidry
Copy link
Collaborator

chrisguidry commented Jun 17, 2024 •
edited
Loading

Another instance: https://github.com/PrefectHQ/prefect/actions/runs/9552028466/job/26327678055?pr=14075

@desertaxle desertaxle self-assigned this Jun 19, 2024
@desertaxle desertaxle mentioned this issue Jun 19, 2024
Closed
5 tasks
@desertaxle desertaxle removed their assignment Jul 9, 2024
@cicdw
Copy link
Member

cicdw commented Nov 12, 2024

I haven't seen this test flake in a long time, closing as resolved

@cicdw cicdw closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce scope of mock patch to prevent crosstalk PrefectHQ/prefect
3 participants
@chrisguidry @desertaxle @cicdw