-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Deployment Version to the Flow Run object #12591
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -619,6 +619,7 @@ async def _generate_scheduled_flow_runs( | |||
"id": uuid4(), | |||
"flow_id": deployment.flow_id, | |||
"deployment_id": deployment_id, | |||
"deplyment_version": deployment.version, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deplyment_version is this an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deplyment_version is this an issue?
It shouldn't be no, but for clarification are you just referring to the naming convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my lack of clarity, was referring to the misspelling (missing o in deployment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yep thanks for flagging that I'll get it updated 😁
This PR adds the deployment version to flow run objects for better traceability/lineage in determining which version of code ran when a flow run was triggered.
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.closes #11983