-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Deployment Version to the Flow Run object #12591
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
18115ed
add deployment version to flow run db model
masonmenges 6766ce6
add deployment version to flowrun schema
masonmenges 69f1398
add deployment version to flowrunresponses schema
masonmenges e5a1f3d
reformatting
masonmenges f2a23cc
add db migrations for sqlite and postgres
masonmenges 900f737
add deployment version to runs from a deployment
masonmenges f80fe47
add test creating flow runs from deployment api
masonmenges 04a09c5
add deployment version to client for flow runs
masonmenges 0f2c8c4
Merge branch 'main' into deployment_version_flow_runs
masonmenges e0455b9
fix revision order
masonmenges 4d0ed19
fix revision order2
masonmenges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
.../versions/postgresql/2024_04_04_094418_bd6efa529f03_add_deployment_version_to_flow_run.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
"""add_deployment_version_to_flow_run | ||
|
||
Revision ID: bd6efa529f03 | ||
Revises: aeea5ee6f070 | ||
Create Date: 2024-04-03 09:44:18.666688 | ||
|
||
""" | ||
import sqlalchemy as sa | ||
from alembic import op | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "bd6efa529f03" | ||
down_revision = "aeea5ee6f070" | ||
branch_labels = None | ||
depends_on = None | ||
|
||
|
||
def upgrade(): | ||
op.add_column( | ||
"flow_run", sa.Column("deployment_version", sa.String(), nullable=True) | ||
) | ||
op.create_index( | ||
op.f("ix_flow_run__deployment_version"), | ||
"flow_run", | ||
["deployment_version"], | ||
unique=False, | ||
) | ||
# ### end Alembic commands ### | ||
|
||
|
||
def downgrade(): | ||
op.drop_index(op.f("ix_flow_run__deployment_version"), table_name="flow_run") | ||
op.drop_column("flow_run", "deployment_version") | ||
# ### end Alembic commands ### |
32 changes: 32 additions & 0 deletions
32
...ions/versions/sqlite/2024_04_04_114538_8644a9595a08_add_deployment_version_to_flow_run.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
"""add_deployment_version_to_flow_run | ||
|
||
Revision ID: 8644a9595a08 | ||
Revises: 07ed05dfd4ec | ||
Create Date: 2024-04-02 11:45:38.210743 | ||
|
||
""" | ||
import sqlalchemy as sa | ||
from alembic import op | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "8644a9595a08" | ||
down_revision = "07ed05dfd4ec" | ||
branch_labels = None | ||
depends_on = None | ||
|
||
|
||
def upgrade(): | ||
op.add_column( | ||
"flow_run", sa.Column("deployment_version", sa.String(), nullable=True) | ||
) | ||
op.create_index( | ||
op.f("ix_flow_run__deployment_version"), | ||
"flow_run", | ||
["deployment_version"], | ||
unique=False, | ||
) | ||
|
||
|
||
def downgrade(): | ||
op.drop_index(op.f("ix_flow_run__deployment_version"), table_name="flow_run") | ||
op.drop_column("flow_run", "deployment_version") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deplyment_version is this an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meggers
It shouldn't be no, but for clarification are you just referring to the naming convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my lack of clarity, was referring to the misspelling (missing o in deployment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yep thanks for flagging that I'll get it updated 😁