Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woof doesn't support "+fullscreen" param, DML still passes it #32

Closed
jmpt16 opened this issue Aug 31, 2023 · 1 comment
Closed

Woof doesn't support "+fullscreen" param, DML still passes it #32

jmpt16 opened this issue Aug 31, 2023 · 1 comment

Comments

@jmpt16
Copy link

jmpt16 commented Aug 31, 2023

line 1497 on MainMenu.cs passes "+fullscreen" param as true/or false, instead of passing fullscreen param only if it is checked.

possible fix:

//FULLSCREEN if (chkFullscreen.Checked) { parm.AppendFormat(" +fullscreen {0} ", chkFullscreen.Checked); }

@Premo36
Copy link
Owner

Premo36 commented Sep 16, 2023

Hi, thanks for the report, a year ago someone reached out via email with the same issue, but as woof! it's not officially supported as v2.5, I'll never publicly released it. Now I've uploaded on my website so anyone that it's using woof can use it. I don't remember how exactly I've fixed that but given that it was a one-time ad hoc fix i think I ended up just commenting the line as you suggested.

https://p36software.net/downloads/DML_v2.5%5BWoof_fullscreen_error_fix%5D.exe

For reference my answer to the email was

I did some testing and from what I can see in this new version woof!
hangs with an error if are passed any parameters outside the one they
have listed in the CONSOLE.txt file. It's not just the +fullscreen, if
for example you try to play with a custom resolution, you'll get an
error that "-width" is not recognised, so be aware that while
+fullscreen is the "problematic" command as it stands out the most (as
it was always passed), many other DML 2.X commands may rise an error if
used.

As I said in my last email I can't fix in the standard v2.5, but I made
a custom build that works with woof! 10.0.1. Note that woof! it's still
unsupported and that this is a special build that will not be mainteined.

The only difference with the normal DML v2.5 is that the +fullscreen
option has been disabled.

To use this version just delete the stock DML .exe and repleace it with
this one.

I will not release this version to the public, but feel free to share it
with anyone is facing your same issue, just be clear with them that this
is not the stock version.

@Premo36 Premo36 closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants