Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline style in install-dev\fixtures\fashion\langs #11212

Closed
wants to merge 1 commit into from
Closed

Remove inline style in install-dev\fixtures\fashion\langs #11212

wants to merge 1 commit into from

Conversation

MathiasReker
Copy link
Contributor

@MathiasReker MathiasReker commented Oct 31, 2018

Questions Answers
Branch? develop
Description? Remove inline styles from test products.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Install data and check if the inline style is gone. Styles should replay on CSS.

This change is Reviewable

@Quetzacoalt91
Copy link
Member

I wonder if we "should" remove the inline style. When we edit these files on the product page, they will have html code in them anyway.
We could start by removing the color from the fields.

@dineshbadrukhiya
Copy link
Contributor

Hello @MathiasReker
Let me inform you to avoid same work 2 times, As @Quetzacoalt91 suggested to start with only color, I have opened PR #11215

@MathiasReker
Copy link
Contributor Author

@dbadrukhiya ofc :) This was just a showcase, I would close the PR again anyway. I was only 3 min of work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants