Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use product url (including combination) rather than canonical one in the miniatures #15964

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Oct 15, 2019

Questions Answers
Branch? 1.7.6.x
Description? A modification was previously integrated in 1.7.6 which used the product canonical url in the miniatures templates This was used to boost SEO and highlight the canonical url but it caused UX issues The url in list could not target a precise combination So we revert back to the original behaviour and use the product url Besides this doesn't affect the SEO since any way all combination urls have the same canonical
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #14765
How to test? Go to a product list and perform a search by criteria, look at the url of a product with combination The url of the miniature must include the combination id (something like /fr/hommes/1-1-hummingbird-printed-t-shirt.html#/1-size-s/8-color-white)

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.2 milestone Oct 15, 2019
@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Oct 15, 2019
@jolelievre jolelievre added this to In progress in PrestaShop 1.7.6 via automation Oct 15, 2019
Copy link
Contributor

matthieu-rolland left a comment

lgtm, thanx @jolelievre !

@jolelievre jolelievre removed this from In progress in PrestaShop 1.7.6 Oct 15, 2019
@jolelievre jolelievre dismissed stale reviews from prestamodule and matthieu-rolland via 2d95ffd Oct 16, 2019
@jolelievre jolelievre force-pushed the jolelievre:product-url branch from 3dfefe1 to 2d95ffd Oct 16, 2019
@matks
matks approved these changes Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 16, 2019

Thank you @jolelievre you are the MVP !

@matks matks merged commit 1298644 into PrestaShop:1.7.6.x Oct 16, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.