Remove deprecated enable_mobile|disable_mobile

[PrestaEdit]

Questions	Answers
Branch?	develop
Description?	Remove the enable_mobile and disable_mobile action from ModuleManager, deprecated since 1.7.3.0
Type?	improvement
Category?	CO
BC breaks?	yes
Deprecations?	no
Fixed ticket	Relative to #26293
How to test?	Use the action on module (enable for mobile
Possible impacts?	n/d

📓 BC break

• Remove method enable_mobile() in src/Core/Addon/Module/ModuleManager.php
• Remove method disable_mobile() in src/Core/Addon/Module/ModuleManager.php

---

This change is 

[prestonBot]

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

• Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

• If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
• It can help trigger a discussion about the best implementation path before a single line of code is written.
• It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

[Hlavtox]

@NeOMakinG Cannot we just completely remove this? Its 2010 stuff.

• Mobile users should have the same experience as desktop.
• We have responsivity.
• What even defines mobile and desktop? We have an infinite range of screen sizes.

[NeOMakinG]

@NeOMakinG Cannot we just completely remove this? Its 2010 stuff.

• Mobile users should have the same experience as desktop.
• We have responsivity.
• What even defines mobile and desktop? We have an infinite range of screen sizes.

I agree, responsive should be enough, this is not the backend responsibility

[kpodemski]

@NeOMakinG @Hlavtox

But this prevents the module from running on mobile devices, which means that if you have a heavy module connecting to the external service, and you want to use it on desktop, and not on mobile - you can. It's completely different than hiding/showing something on mobile.

[Hlavtox]

No module should be that heavy that it should not be loaded on mobile. Usually over 60% of all customers access the web from mobile devices, they need to have the same experience as on desktop. ;-)

[kpodemski]

Let's leave that decision on what customers should, or shouldn't have to the developers 👍 I can imagine some scenarios, especially related to the B2B stores where this feature can be helpful :-)

[AureRita]

I tested it and the variable seems to be correctly changed,

as we can see on this picture

the module manager have 75 utilisation of disableMobile (on Mozilla)

It seems to be the same on google

there is no use of _mobile

[NeOMakinG]

Thanks @PrestaEdit

I really think that this PR will create a lot of wrong behaviors on different modules, be prepared to get some issues about it!

[PrestaEdit]

Doesn't see why, as you are still able to enable/disable mobile devices for somes modules. It's just the old methods (not used by module itself) that are removed, not the feature.

[NeOMakinG]

Doesn't see why, as you are still able to enable/disable mobile devices for somes modules. It's just the old methods (not used by module itself) that are removed, not the feature.

Oh ok, thanks for the precision!

[matks]

I think we also need to document BC break inside https://devdocs.prestashop.com/8/modules/core-updates/8.0/ so I keep the label "Needs documentation"