Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the wording translation for Enable/Disable Mobile in Modules page #28023

Merged
merged 1 commit into from Apr 1, 2022
Merged

Fixed the wording translation for Enable/Disable Mobile in Modules page #28023

merged 1 commit into from Apr 1, 2022

Conversation

Progi1984
Copy link
Contributor

@Progi1984 Progi1984 commented Mar 23, 2022 •
edited by PierreRambaud

Questions Answers
Branch? develop
Description? Fixed the wording translation for Enable/Disable Mobile in Modules page (Bug inherited from #27527 (ping @PrestaEdit))
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #28000
How to test? Cf. #28000

This change is Reviewable

@Progi1984 Progi1984 requested a review from a team as a code owner March 23, 2022 16:27
@Progi1984 Progi1984 added this to the 8.0.0 milestone Mar 23, 2022
@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix Waiting for wording Status: action required, waiting for wording labels Mar 23, 2022
NeOMakinG
NeOMakinG previously approved these changes Mar 24, 2022
View reviewed changes
atomiix
atomiix previously approved these changes Mar 24, 2022
View reviewed changes
@Progi1984 Progi1984 closed this Mar 24, 2022
@Progi1984 Progi1984 reopened this Mar 24, 2022
@Julievrz Julievrz removed the Waiting for wording Status: action required, waiting for wording label Mar 24, 2022
@Progi1984 Progi1984 added the Waiting for QA Status: action required, waiting for test feedback label Mar 24, 2022
@florine2623 florine2623 self-assigned this Mar 24, 2022
florine2623
florine2623 requested changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Thanks for the PR !

Could you also change the wording in the alert ?
I should have Disable Mobile instead of DisableMobile

What I have What I should have
Screenshot 2022-03-24 at 15 05 59Screenshot 2022-03-24 at 15 06 18 Screenshot 2022-03-24 at 15 06 42Screenshot 2022-03-24 at 15 06 54

Thanks!

@florine2623 florine2623 added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 24, 2022
@Progi1984 Progi1984 dismissed stale reviews from atomiix and NeOMakinG via bfdcaab March 25, 2022 13:45
@Progi1984 Progi1984 removed the Waiting for author Status: action required, waiting for author feedback label Mar 25, 2022
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Mar 25, 2022
@Progi1984 Progi1984 removed the Waiting for wording Status: action required, waiting for wording label Mar 25, 2022
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Mar 29, 2022
@Progi1984 Progi1984 removed the Waiting for wording Status: action required, waiting for wording label Mar 29, 2022
@Progi1984 Progi1984 requested a review from PululuK March 29, 2022 20:41
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Mar 30, 2022
@Progi1984 Progi1984 removed the Waiting for wording Status: action required, waiting for wording label Mar 30, 2022
@Progi1984 Progi1984 requested a review from atomiix March 30, 2022 13:29
jolelievre
jolelievre previously approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Progi1984

All good for me, although adding the configure const would be a nice extra improvement for this PR

src/Adapter/Module/AdminModuleDataProvider.php Outdated Show resolved Hide resolved
src/Adapter/Module/AdminModuleDataProvider.php Show resolved Hide resolved
@prestonBot prestonBot added the Waiting for wording Status: action required, waiting for wording label Apr 1, 2022
@Progi1984 Progi1984 removed the Waiting for wording Status: action required, waiting for wording label Apr 1, 2022
NeOMakinG
NeOMakinG approved these changes Apr 1, 2022
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front lgtm

@atomiix atomiix added the Waiting for QA Status: action required, waiting for test feedback label Apr 1, 2022
florine2623
florine2623 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Tested : Install, Uninstall, Disable, Enable, Reset, Enable Mobile, Disable Mobile on native and non-native modules.
Action works well, error message is correct.

LGTM, QA ✅ !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 1, 2022
@Progi1984 Progi1984 merged commit 326a1f7 into PrestaShop:develop Apr 1, 2022
@Progi1984 Progi1984 deleted the issue28000 branch April 1, 2022 12:05
@Progi1984
Copy link
Contributor Author

Thanks @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

@NeOMakinG NeOMakinG NeOMakinG approved these changes

@florine2623 florine2623 florine2623 approved these changes

@PululuK PululuK Awaiting requested review from PululuK

@jolelievre jolelievre Awaiting requested review from jolelievre

Assignees

@florine2623 florine2623

Labels
Bug fix Type: Bug fix develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

BO - Module Manager - The button Disable mobile is not well displayed
8 participants
@Progi1984 @atomiix @jolelievre @NeOMakinG @florine2623 @PululuK @prestonBot @Julievrz