Prevent error when id_product_attribute is empty #4545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ramtin2025 , thank you for this PR! Could you give more details about what you are making? Also, could you follow the guidelines for PR and commit titles? Thank you! |
|
@xBorderie from what I see id_product_attribute is required for StockAvailable object but not really. IMO it should be defined as 0 in StockAvailable.php here https://github.com/PrestaShop/PrestaShop/blob/develop/classes/stock/StockAvailable.php#L39 what you think @ramtin2025 ? |
xBorderie
added
advanced stock management
Waiting for rebase
xBorderie
added a commit
that referenced
this pull request
Mar 23, 2016
Inspired by this thread: https://www.prestashop.com/forums/topic/483630-bug-161-1-1612-classesstockstockavailablephp/ Also, see #4545 for a first PR attempting to fix this.
xBorderie
added a commit
that referenced
this pull request
Mar 23, 2016
Inspired by this thread: https://www.prestashop.com/forums/topic/483630-bug-161-1-1612-classesstockstockavailablephp/ Also, see #4545 for a first PR attempting to fix this.
|
Fixed with #5241. Thank you! |
xBorderie
removed
Estimate: S
Waiting for rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent error when id_product_attribute is empty