Fix fatal error on classes/stock/StockAvailable.php #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by this thread: https://www.prestashop.com/forums/topic/483630-bug-161-1-1612-classesstockstockavailablephp/ Also, see #4545 for a first PR attempting to fix this.
maximebiloe
added
Code reviewed
Waiting for QA
|
The same bug was fixed in the same manner for |
maximebiloe
changed the title
maximebiloe
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the classes/stock/StockAvailable.php is left as is some products would cause the payment window to hang and the page will never redirect. I turned on developer mode to get this error.
Fatal error: Uncaught exception 'PrestaShopException' with message 'Property StockAvailable-id_product_attribute is empty'See #5242 for the
1.6.1.xPR of this commit.Also, see #4545 for a first PR attempting to fix this.