Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] FO : Add display after carrier list hook #5346

Merged
merged 1 commit into from
Apr 14, 2016
Merged

[+] FO : Add display after carrier list hook #5346

merged 1 commit into from
Apr 14, 2016

Conversation

firstred
Copy link
Contributor

Description

Add a hook to display information after the carrier list

Steps to Test this Fix

Step 1. Create a new module
Step 2. Hook some HTML to displayAfterCarrier
Step 3. Check if output is shown

@PrestaEdit
Copy link
Contributor

Hi,

I think you forgot to commit somes changes (like pass the var to smarty) or maybe you want to use the {hook h='displayAfterCarrier'} method inside the template. No ?!

@firstred
Copy link
Contributor Author

Yep! It's just there to be displayed, just like the displayBeforeCarrier hook.

@PrestaEdit
Copy link
Contributor

Right, but $hookDisplayAfterCarrier is never declared/assigned. I really think you wanna write something like: {hook h='displayAfterCarrier' nofilter}

@firstred
Copy link
Contributor Author

Indeed! Thank you for the information.

I have now added it to $extraParams and pass the Cart object, just like hookDisplayBeforeCarrier.

@PrestaEdit
Copy link
Contributor

Right ! It's now more better, ;-)

@maximebiloe maximebiloe merged commit 411e1d7 into PrestaShop:develop Apr 14, 2016
@maximebiloe
Copy link
Contributor

Thanks for this contribution.

Could you report this change into the StarterTheme, please?

Shudrum pushed a commit that referenced this pull request Apr 14, 2016
[+] FO : Add display after carrier list hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants