Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BO: Combination dropdown visibility #8144

Closed
wants to merge 1 commit into from
Closed

BO: Combination dropdown visibility #8144

wants to merge 1 commit into from

Conversation

idnovate
Copy link
Contributor

@idnovate idnovate commented Jul 14, 2017 •
edited by marionf
Loading

When you load a cart rule with a gift product and the gift product search found more than 1 product, all the combination dropdowns are visible.

Questions Answers
Branch? 1.6.1.x
Description? Only the product's combination dropdown is displayed
Type? bug fix
Category? BO
BC breaks? No
Deprecations? No
Fixed ticket? Fixes #15529
How to test? Create 2 products with a similar reference (ex. 'AA', 'AAA'). Create a cart rule with gift product 'AA'. Load cart rule.

Important guidelines

This change is Reviewable

@idnovate
BO: Combination dropdown visibility
48a32fa 
When you load a cart rule with a gift product and the gift product search found more than 1 product, all the combination dropdowns are visible.
@eternoendless eternoendless added Waiting for QA Status: action required, waiting for test feedback Code reviewed labels Sep 1, 2017
@marionf
Copy link
Contributor

marionf commented Oct 4, 2017

Hello @idnovate
I am not sure to understand the issue and what you solve.

  1. I created a product with "aa" for name and reference. This product has 2 combinations: red & white.
  2. I created a product with "aaa" for name and reference. This product has 2 combinations: green & black.
  3. I create a cart rule with a free gift.
  4. When I search "aa", it find nothing -> this is not working

cart rule aa

  1. When I search "aaa" it find the product with combinations green & black -> it's working.

cart rule aaa

What your PR solves ?

@marionf marionf added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Oct 4, 2017
@idnovate
Copy link
Contributor Author

idnovate commented Oct 4, 2017

Sorry, it start searching from 3 characters onwards.
So to reproduce the problem please:

  • Create a product with name and reference "AAA" with 2 combinations.
  • Create a product with name and reference "AAAA" with 2 combinations.
  • Create a cart rule with "AAA" as gift product. Save the rule.
  • Load the rule and you will see 2 dropdowns, one with "AAA" combinations and another with "AAAA" combinations.

Thanks.

@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for author Status: action required, waiting for author feedback labels Oct 5, 2017
@matks
Copy link
Contributor

matks commented Sep 12, 2019

@marionf if this bug is still happening in 1.7, we should be able to fix it thanks to this PR. It will also probably be fixed by the migration

@idnovate
Copy link
Contributor Author

Still happens and PR is still valid

@PierreRambaud
Copy link
Contributor

@idnovate Could you please rebase your branch to develop branch?

@marionf marionf mentioned this pull request Sep 13, 2019
Closed
@prestonBot prestonBot added the Bug Type: Bug label Sep 13, 2019
@idnovate
Copy link
Contributor Author

#15546

@PierreRambaud
Copy link
Contributor

Closed in favor of #15546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@idnovate @marionf @matks @PierreRambaud @eternoendless @mickaelandrieu @prestonBot