Skip to content

Commit

Permalink
Update image for PR process and add tips to see image in full size
Browse files Browse the repository at this point in the history
  • Loading branch information
matks committed Jul 30, 2020
1 parent e2f4426 commit a7ad89b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/content/1.7/contribute/contribution-guidelines/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Do not hesitate to use [interactive staging](https://git-scm.com/book/en/v2/Git-
{{% /notice %}}

{{% callout %}}

### Writing a good commit message

The commit name should give an idea of the nature and context of the change that has been done. The more details, the better! The commit name should be as unique and recognizable as your commit itself. There are multitude of articles on the web regarding commit messages, here are two that you can find useful: [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/) and [What makes a good commit message?](https://hackernoon.com/what-makes-a-good-commit-message-995d23687ad).
Expand Down Expand Up @@ -126,6 +127,8 @@ Remember: **smaller changes are easier to review, easier to test and easier to m

When you create a new Pull Request, you will be presented with a form that looks like this:

(click on it to see full size)

![Screenshot of the New Pull Request Form](../img/new-pull-request.png)

The first step is to write a summary of your pull request's purpose in its GitHub title.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ After the Pull Request has finally passed the QA validation, it is merged in the

### Graphical summary

(click on it to see full size)

![Pull Request process summary](../../img/pull-request-process.png)


Expand Down
Binary file modified src/content/1.7/contribute/img/pull-request-process.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit a7ad89b

Please sign in to comment.