Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give an example on how to handle translation of Javascript strings. #1344

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Give an example on how to handle translation of Javascript strings. #1344

merged 1 commit into from
Apr 4, 2022

Conversation

lmeyer1
Copy link
Contributor

@lmeyer1 lmeyer1 commented Apr 4, 2022

Questions Answers
Branch? 1.7.x
Description? Give an example on how to handle translation of Javascript strings in smarty templates.
Fixed ticket? Fixes #1342

@lmeyer1 lmeyer1 changed the base branch from 8.x to 1.7.x April 4, 2022 12:59
@github-actions github-actions bot added the 8.x label Apr 4, 2022
matthieu-rolland
matthieu-rolland approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition 👍

@matks
Copy link
Contributor

matks commented Apr 4, 2022

Thank you @lmeyer1

@matks matks merged commit aa217ab into PrestaShop:1.7.x Apr 4, 2022
@matks
Copy link
Contributor

matks commented Apr 4, 2022

@lmeyer1 Do you think you could submit a backport PR for 8.x branch? 😄

@matks matks mentioned this pull request Apr 4, 2022
Closed
@lmeyer1 lmeyer1 mentioned this pull request Apr 4, 2022
Merged
@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Apr 4, 2022

@matks Done. Backport PR #1345

@lmeyer1 lmeyer1 mentioned this pull request Apr 4, 2022
Merged
@lmeyer1
Copy link
Contributor Author

lmeyer1 commented Apr 4, 2022

Sorry, there was an markdown syntax error. I opened a new PR #1346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@matks matks matks approved these changes

Assignees
No one assigned
Labels
1.7.x Backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new translator to translate Javascript-save strings
3 participants
@lmeyer1 @matks @matthieu-rolland