Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar complexity and punctuation. #15

Closed
wants to merge 2 commits into from
Closed

Grammar complexity and punctuation. #15

wants to merge 2 commits into from

Conversation

inetbiz
Copy link

@inetbiz inetbiz commented Aug 8, 2016

Hemingway app found several instances of difficult sentences, excessive use of passive voice and adverbs. I also found run-on sentences and links that should have been an anchor text link.

@inetbiz
Copy link
Author

inetbiz commented Aug 8, 2016

@xBorderie Here's the first page of changes.


Nearly 2000 themes are available through the PrestaShop Addons marketplace (http://addons.prestashop.com/en/). They were created either by members of the PrestaShop community or the PrestaTeam, and are sold at reasonable prices – some are even free.
There are over 2,000 themes available through the [**PrestaShop Addons Marketplace**] (http://addons.prestashop.com/en/). Created by members of the PrestaShop community or the PrestaTeam. And, sold at reasonable prices – some are even free.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm okay with cutting long sentences in two (or more) and starting sentences with a conjunction, the whole 'follow a conjunction with a comma' thing here is a big no-no to me. I agree with the best answer here: "a comma is a “disjunction”, and defeats the purpose of the conjunction". Please update the PR accordingly.

@xBorderie
Copy link

Thank you for proofreading this! Please update the PR according to my indication, and we should be good to go :)

Made changes requested plus a few spelling errors and markdown syntax fixes, headings.
@inetbiz
Copy link
Author

inetbiz commented Aug 8, 2016

I've never used RST before. Should I close the PR and use an online RST editor?


Nearly 2000 themes are available through the PrestaShop Addons marketplace (http://addons.prestashop.com/en/). They were created either by members of the PrestaShop community or the PrestaTeam, and are sold at reasonable prices – some are even free.
There are over 2,000 themes available through the [**PrestaShop Addons Marketplace**] (http://addons.prestashop.com/en/). Created by members of the PrestaShop community or the PrestaTeam. And sold at reasonable prices – some are even free.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong way to format a link: this a the Mardown way, in a RST document.

@xBorderie
Copy link

I've never used RST before. Should I close the PR and use an online RST editor?

I think it's best to stop this PR, yeah.
The /docs files use the RST format, so if you want to proofread the English text (and please, do not rewrite everything the HemingwayApp way), you must either learn the syntax, or use a WYSIWYG editor (I gave a shot to this one).

Thank you!

@xBorderie
Copy link

Closing this PR for now. Thanks!

@xBorderie xBorderie closed this Aug 24, 2016
mickaelandrieu pushed a commit that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants