Documents Bulk actions for Grid component #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matks
reviewed
Apr 12, 2019
src/content/1.7/development/components/grid/tutorials/work-with-bulk-actions.md
Outdated
Show resolved
Hide resolved
matks
reviewed
Apr 12, 2019
src/content/1.7/development/components/grid/tutorials/work-with-bulk-actions.md
Outdated
Show resolved
Hide resolved
matks
reviewed
Apr 12, 2019
src/content/1.7/development/components/grid/tutorials/work-with-bulk-actions.md
Show resolved
Hide resolved
matks
reviewed
Apr 12, 2019
src/content/1.7/development/components/grid/tutorials/work-with-bulk-actions.md
Outdated
Show resolved
Hide resolved
|
👏 Do you think it would be relevant here to quickly explain how BulkActions require a dedicated Controller to handle the route they link to (for example SubmitBulkAction has a 'submit_route' option that needs to be given a valid SF route name to handle the submit process) ? Or maybe that's for another PR |
|
I think that should be part of another section. As this is required for other actions as well. |
Co-Authored-By: sarjon <jonusas.sarunas@gmail.com>
Co-Authored-By: sarjon <jonusas.sarunas@gmail.com>
|
@matks addressed all your suggestions. |
|
Thank you @sarjon |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.