Add a reworked dedicated page for "how to create a PR" #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matks
commented
Feb 27, 2020
| If you do not know how to do it, you can read [GitHub documentation](https://help.github.com/articles/creating-a-pull-request/). | ||
|
|
||
| If you find this process quite complex, the following materials can help you (on dev.to): | ||
| - [The SIMPLEST way to make a pull request](https://dev.to/lukegarrigan/the-simplest-way-to-make-a-pull-request-2h61) |
There was a problem hiding this comment.
I added 2 helpful links
|
|
||
| Once your changes sound good and tests pass on your local computer, it's time to publish your work online and make a pull request. | ||
| See [next page]({{</* ref "1.7/contribute/create-pull-request.md" */>}}) |
There was a problem hiding this comment.
What's up with the /* ... */ ?
|
|
||
| # Publish your contribution on GitHub | ||
|
|
||
| Once your changes sound good and tests pass on your local computer, you can submit these changes as a Pull Request on GitHub in order to contribute to the opensource project. |
There was a problem hiding this comment.
Suggested change
| Once your changes sound good and tests pass on your local computer, you can submit these changes as a Pull Request on GitHub in order to contribute to the opensource project. | |
| Once your changes sound good and tests pass on your local computer, you can contribute to the open source project by submitting these changes as a Pull Request on GitHub. |
| git push origin add-emoticons-support | ||
| ``` | ||
|
|
||
| > You will need to use your GitHub credentials. |
There was a problem hiding this comment.
Suggested change
| > You will need to use your GitHub credentials. | |
| {{% notice note %}} | |
| You will need to use your GitHub credentials. | |
| {{% /notice %}} |
Comment on lines
18
to
20
| Now you can create your Pull Request on GitHub. | ||
|
|
||
| If you do not know how to do it, you can read [GitHub documentation](https://help.github.com/articles/creating-a-pull-request/). |
There was a problem hiding this comment.
Suggested change
| Now you can create your Pull Request on GitHub. | |
| If you do not know how to do it, you can read [GitHub documentation](https://help.github.com/articles/creating-a-pull-request/). | |
| Now you can create your Pull Request on GitHub. If you don't know how to do it, you can read [GitHub documentation](https://help.github.com/articles/creating-a-pull-request/). |
|
|
||
| If you do not know how to do it, you can read [GitHub documentation](https://help.github.com/articles/creating-a-pull-request/). | ||
|
|
||
| If you find this process quite complex, the following materials can help you (on dev.to): |
There was a problem hiding this comment.
Suggested change
| If you find this process quite complex, the following materials can help you (on dev.to): | |
| If you find this process quite complex, the following articles can help you: |
I don't think it's useful to cite the source if you're linking to it.
| - [The SIMPLEST way to make a pull request](https://dev.to/lukegarrigan/the-simplest-way-to-make-a-pull-request-2h61) | ||
| - [The github workflow explained](https://dev.to/mathieuks/introduction-to-github-fork-workflow-why-is-it-so-complex-3ac8) | ||
|
|
||
| > Do not forget to complete the contribution table, this is really important for the Core Team to really understand what is the value of your contribution. |
There was a problem hiding this comment.
Maybe link to the contribution guidelines instead?
Comment on lines
31
to
32
| PrestaShop Core is a really active project with more than 30 contributions accepted per week, so your copy will become outdated | ||
| really fast. To make your own copy up to date with the original project, only a few commands are required: |
There was a problem hiding this comment.
Suggested change
| PrestaShop Core is a really active project with more than 30 contributions accepted per week, so your copy will become outdated | |
| really fast. To make your own copy up to date with the original project, only a few commands are required: | |
| PrestaShop Core is a really active project with more than 30 contributions accepted per week, so your fork will become outdated really fast. To make your own copy up to date with the original project, only a few commands are required: |
| PrestaShop Core is a really active project with more than 30 contributions accepted per week, so your copy will become outdated | ||
| really fast. To make your own copy up to date with the original project, only a few commands are required: | ||
|
|
||
| > You need to execute these commands at the root of your copy/fork. |
There was a problem hiding this comment.
Suggested change
| > You need to execute these commands at the root of your copy/fork. | |
| {{% notice note %}} | |
| You need to execute these commands at the root of your copy/fork. | |
| {{% /notice %}} |
|
Applied @eternoendless feedbacks in bfba62f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.