Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing brands select into boostrap dropdown #6

Merged
merged 5 commits into from
Dec 2, 2019
Merged

Changing brands select into boostrap dropdown #6

merged 5 commits into from
Dec 2, 2019

Conversation

NeOMakinG
Copy link

Questions Answers
Branch? develop
Description? The select of brand module on category page is ugly, let's use a bootstrap dropdown we already use on this page
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9670
How to test? Install the ps_brandlist module, then change the configuration to dropdown instead of plain text

This change is Reviewable

@NeOMakinG NeOMakinG mentioned this pull request Nov 25, 2019
Merged
@PierreRambaud PierreRambaud changed the base branch from master to dev November 25, 2019 10:59
Valentin Szczupak and others added 2 commits November 25, 2019 12:04
Deleting useless option
4b0d116
@PierreRambaud
Adding new line to the end of the file
ca230fb 
Co-Authored-By: GoT <PierreRambaud@users.noreply.github.com>
@PierreRambaud PierreRambaud added the waiting for QA Status: Waiting for QA feedback label Nov 25, 2019
@sarahdib sarahdib added QA ✔️ and removed waiting for QA Status: Waiting for QA feedback labels Dec 2, 2019
@Progi1984 Progi1984 merged commit cdebc4d into PrestaShop:dev Dec 2, 2019
@matks matks added this to the 1.0.3 milestone Jan 6, 2022
@matks matks mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@NeOMakinG @PierreRambaud @Progi1984 @sarahdib @matks