-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.1.0 #38
Merged
Release 2.1.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #16. Since `$sharing_url`, `$sharing_name` and `$sharing_img` are only used as URL parameters, they should all be URL encoded. I found this problem when a product name with a % sign in it was causing twitter to give an HTTP status code 4xx.
Remove Google+
Single blank line at EOF
…espace Trailing comma in multiline array
Lossless compression
Test isset of var
Update readme to add multistore compatibility
Short array syntax
…semicolons Multiline whitespace before semicolons
Clean license headers and readme
Bump to version 2.1.0
Replace http with https for socials URLs
Add GitHub PR template
Enable Release Drafter
Encode URL to follow RFC 1866 (another attempt)
PierreRambaud
approved these changes
May 13, 2020
NeOMakinG
approved these changes
May 13, 2020
hey @Progi1984 @NeOMakinG please take a look at this issue: it's worth considering before release of new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.