Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 #38

Merged
merged 33 commits into from
May 20, 2020
Merged

Release 2.1.0 #38

merged 33 commits into from
May 20, 2020

Conversation

Progi1984
Copy link
Member

No description provided.

PrestaEdit and others added 30 commits July 10, 2017 12:16
See #16.  Since `$sharing_url`, `$sharing_name` and `$sharing_img` are only used as URL parameters, they should all be URL encoded.  I found this problem when a product name with a % sign in it was causing twitter to give an HTTP status code 4xx.
…espace

Trailing comma in multiline array
Update readme to add multistore compatibility
…semicolons

Multiline whitespace before semicolons
Replace http with https for socials URLs
Add GitHub PR template
matks and others added 3 commits April 1, 2020 18:08
Enable Release Drafter
Encode URL to follow RFC 1866 (another attempt)
@Progi1984 Progi1984 requested a review from a team May 13, 2020 08:41
@Progi1984 Progi1984 requested a review from a team May 13, 2020 09:02
@Progi1984 Progi1984 added the waiting for QA Status: Waiting for QA feedback label May 13, 2020
@kpodemski
Copy link
Contributor

hey @Progi1984 @NeOMakinG

please take a look at this issue:
https://github.com/PrestaShop/ps_sharebuttons/issues/39

it's worth considering before release of new version

@sarahdib sarahdib self-assigned this May 20, 2020
@sarahdib sarahdib added QA ✔️ and removed waiting for QA Status: Waiting for QA feedback labels May 20, 2020
@Progi1984 Progi1984 merged commit 2a03027 into master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.